-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
morphapi
external dependency is not available on conda-forge
#9
Comments
Is there any reason we can't put |
Will make |
Some other BrainGlobe dependencies have been added by people who aren't the maintainers of the original package (NiftyReg, and I think some others). I don't know if there are rules, but I think the etiquette is to ask the developers if they have any plans to add it. If they don't, then we can add it. @adrien-berchet do you know anything about the plans here?
100% |
Hi! |
@adrien-berchet We'd be happy to add the recipe and add the correct people as maintainers if that's alright? |
That could work indeed, thanks. Just wait a bit to figure out who should maintain this recipe (will be discussed in BlueBrain/NeuroM#1074). |
So your solution is fine for us! |
@willGraham01 are you happy to look into this so we can get MorphIO -> NeuroM -> BrainGlobe onto conda? |
Yep happy to take a look into this, this week 👍 |
Just posting an update on this after radio silence for 2 weeks; I have a recipe PR open for MorphIO (the NeuroM dependency). I've hit a bug in the build process that I'm 99% confident is an issue specific to the way |
Hi @willGraham01 |
Hi Adrien - I was actually waiting on response from the conda-forge team, but they never got back to me about the issue I was encountering (essentially the build process wouldn't complete because of missing headers and libraries not being found, and I could only replicate this bug on conda-CI... everything else worked fine in EG a mamba image or local build). Since the PR was going stale, it was closed. We've just finished a large restructuring of BrainGlobe, and now default to I'm happy to share any insights I learnt with you or anyone else in your team if you're going to attempt this yourselves in the near future. |
Yeah, I saw they never answered :-/ |
Describe the bug
morphapi
's dependencyNeuroM
is available on PyPI, but not on conda-forge. This means that we can't uploadmorphapi
toconda-forge
, and hence neither can we uploadbrainglobe
either.To Reproduce
will report the missing conda-forge dependency. Searching conda-forge will verify this.
Possible Solutions
morphapi
as an optional dependency inbrainglobe
? Then theconda-forge
recipe can only be for the "base"brainglobe
?The text was updated successfully, but these errors were encountered: