DO NOT MERGE THIS #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Napo2k
commented
Feb 5, 2021
| for setting in required_settings: | ||
| if not setting in app.config: | ||
| raise RuntimeError("Flask-GitHubApp requires the '%s' config var to be set" % setting) | ||
| if setting not in app.config: |
There was a problem hiding this comment.
I think this was some PEP8 recommendation PyCharm made?
Napo2k
commented
Feb 5, 2021
| @@ -99,7 +99,7 @@ def client(self): | |||
| @property | |||
| def payload(self): | |||
| """GitHub hook payload""" | |||
| if request and request.json and 'installation' in request.json: | |||
| if request and request.json: | |||
| return request.json | |||
|
|
|||
| raise RuntimeError('Payload is only available in the context of a GitHub hook request') | |||
There was a problem hiding this comment.
I was hitting this runtime error... so I removed the installation check. YOLO
¯_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember @bradshjg wanted to know what sorts of problems I was running into.
Well, I can't really remember what the problems were but I did start using my own branch whenever I found them, just because I wanted to keep developing my app (something else I am failing on for now, but that's my problem :D )
FWIW, we use GitHub 2.22.5, so there might be some issues coming from there, perhaps.
I have no intention of merging this!! It's just a way to show you the issues I have had.