Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search improvements #2187

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Search improvements #2187

wants to merge 2 commits into from

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jun 3, 2024 •
edited
Loading

Improves search by

  • sorting matches by location (when searching for "foo", "foo bar" will appear before "bar foo")

brave_noS564awP1

Related to bpmn-io/diagram-js#913

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 3, 2024
@philippfromme philippfromme mentioned this pull request Jun 3, 2024
Open
@philippfromme philippfromme marked this pull request as ready for review June 5, 2024 14:05
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 5, 2024
@philippfromme
feat(search): sort matches by location
5200d17 
* simplify implementation
* take location into account when sorting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku Awaiting requested review from nikku

@marstamm marstamm Awaiting requested review from marstamm

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
needs review Review pending
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@philippfromme