This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Add's the uopz's extension #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| include boxen::config | ||
|
|
||
| require php::config | ||
| # Require php version eg. php::5_4_10 |
There was a problem hiding this comment.
This comment uses the old syntax. Can you please update to the new syntax or remove it to avoid confusion?
|
Could you explain what you mean? I've been comparing the syntax here to other extensions in the directory, but can't spot what the difference is. Happy to make the changes on all three pull requests, but need a bit more guidance. |
|
From TFM: You will need to change any code in your manifests like Let me know if this doesn't make sense. |
|
Right, I get it now - the same syntax is in the comment for every other extension, so I couldn't see what what I'd one wrong. Back in a bit with an updated version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows modification of the exit language construct etc.
Has a spec file.