Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to change$\bar{c}$ in the TLS/GM function.
Originally, in$\bar{c}$ is always set to 1.
gtsam/nonlinear/GncOptimizer.h
,We add a
barc
parameter togtsam/nonlinear/GncParams.h
, thereby we can setbarcSq
with respect tobarc
We also tested it in
examples/GNCExample.cpp
In addition, there are other ways to set
barcSq
ingtsam/nonlinear/GncOptimizer.h
These two functions are not used in the origin GNC implementation, thus I am not sure what$\bar{c}^2$ in $\bar{c}^2$ directly if known, so I left it unchanged.
inth
is. It seems likeinth
isgtsam/test/testGncOptimizer.cpp
and is meant to set to