Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster DecisionTree #1875

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Faster DecisionTree #1875

merged 5 commits into from
Oct 15, 2024

Conversation

dellaert
Copy link
Member

Several improvements yield maybe 5% speedup in hybrid (I thought it'd be more, mileage may vary):

  • Make several methods static
  • Add a convertFrom that does not do "Shannon expansion" as labels are not changed
  • Make push_back take an r-value and use std::move where used

varunagrawal
varunagrawal approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@varunagrawal varunagrawal merged commit db353a5 into develop Oct 15, 2024
33 checks passed
@varunagrawal varunagrawal deleted the feature/fasterDT branch October 15, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal