Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better HybridNonlinear! #1851

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Better HybridNonlinear! #1851

merged 4 commits into from
Sep 29, 2024

Conversation

dellaert
Copy link
Member

  • Pulled out hybrid motion model tests
  • switched to NoiseModelFactor to be stored in HNF: no more manual adding of constants needed!

varunagrawal
varunagrawal approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the noiseModel classes is the gift that keeps on giving. 😊

gtsam/hybrid/tests/testHybridBayesNet.cpp Show resolved Hide resolved
gtsam/hybrid/tests/testHybridEstimation.cpp Show resolved Hide resolved
gtsam/hybrid/tests/testHybridGaussianISAM.cpp Show resolved Hide resolved
gtsam/hybrid/tests/testHybridNonlinearFactorGraph.cpp Show resolved Hide resolved
gtsam/hybrid/tests/testHybridNonlinearISAM.cpp Show resolved Hide resolved
gtsam/hybrid/HybridNonlinearFactor.cpp Outdated Show resolved Hide resolved
@varunagrawal
Copy link
Collaborator

Left some comments, which should be easy to fix along with the wrapper.

@dellaert dellaert merged commit 8816374 into develop Sep 29, 2024
33 checks passed
@dellaert dellaert deleted the feature/linearize branch September 29, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal