-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore stubgen errors and wrap TriangulationFactor #1846
Conversation
I think it does not matter? Mypy has the same issue, they just pretend that it does not exist, the generated signature is |
Yes but at least we don't get bombarded by a bunch of error messages. Those error messages are very misleading and for someone not familiar with the wrapper and stub generation, it can be very confusing. |
I see, if that's the use case the only change needed is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Until #1824 is addressed, I suggest we keep using mypy's stubgen.
I've kept the
#include<algorithm>
for compilation.Additionally, fixes #1758.
Updated to also address #1791.