Small runtime improvement for hybrid #1844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Targeting branch from #1843, develop after that's merged]
Using instruments I was profiling testHybridEstimation, and I discovered a small gain (a few %) by making the DecisionTreeFactor::combine a bit more efficient.
However, @varunagrawal, I also noticed that
augment
in HGF is one of the heaviest hitters - probably 10-20%. This is not surprising, as this where the "hiding" happens, which is expensive and not needed. The negLogConstants can just be added during elimination,and we probably gain in the QR calls as well. The hiding has no benefit except that we would not have to rewrite a tiny part of the math :-/