Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases for IncrementalFixedLagSmoother #1795

Closed
wants to merge 1 commit into from

Conversation

truher
Copy link
Contributor

@truher truher commented Aug 16, 2024

two cases here:

  • SEGV while marginalizing a variable with only a prior.
  • IndexError during marginalization that seems distantly caused by the behavior of update()?

@ProfFan
Copy link
Collaborator

ProfFan commented Aug 16, 2024

Thanks! The IncrementalFixedLagSmoother has been known to have problems. There are several workarounds in the issues section, but none of us have the bandwidth for the bugfix right now.

@truher
Copy link
Contributor Author

truher commented Aug 16, 2024

no worries, i appreciate your quick response. i can avoid these particular issues, though i'm concerned that there may be more issues lurking in the future. is there a better choice than IncrementalFixedLagSmoother ? The "batch" version doesn't seem to have implemented the marginalCovariance method, which I kinda want.

@dellaert
Copy link
Member

dellaert commented Aug 16, 2024

I appreciate the tests and might take a look. I have been seeing some other segfaults with 3.12.
What version of python are you using?

@truher
Copy link
Contributor Author

truher commented Aug 16, 2024

thank you! i know you're very busy.

re: python version, i'm using 3.10.12, on ubuntu 22.04.

@truher
Copy link
Contributor Author

truher commented Aug 25, 2024

closed so i can have the "develop" branch back.

see #1809

@truher truher closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants