Update Wrapper #1712
Merged
Update Wrapper #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcf23207 Merge pull request #163 from borglab/dunder-methods 22d429cc2 use STL functions instead of container methods abe8818ab update pyparsing to 3.1.1 a9e896d0c add unit tests 535fe4f14 wrap supported dunder methods 079687eac parse dunder methods in interface file git-subtree-dir: wrap git-subtree-split: cdcf23207fbb03457c5d9dbfc2b0b57e515b5f3d
varunagrawal
added
python
gchenfc
approved these changes
Jan 16, 2024
gtsam/gtsam.i
Outdated
| @@ -39,6 +39,11 @@ class KeyList { | |||
| void remove(size_t key); | |||
|
|
|||
| void serialize() const; | |||
|
|
|||
| // Specual dunder methods for Python wrapping | |||
There was a problem hiding this comment.
Corrected! I agree with the comment about .find() but until we move to C++20, many C++ STL containers won't support a find method. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the wrapper with new functionality supporting a new double-underscore (dunder) syntax. This makes wrapping classes that should exhibit some behavior in Python easier.
E.g. there is an ask in #1606 for
KeySetto allow iteration and other container based operations. By adding__iter__and__contains__dunder methods to thegtsam.ifile, we now support those operations.This means we can now do this:
Consequently, fixes #1606.