Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom loss function for Robust, fix a bug in Asymmetric #1607

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented Aug 18, 2023

Add a way to use a custom loss function without changing GTSAM code

@ProfFan ProfFan requested a review from dellaert August 18, 2023 21:11
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome!
But please add a unit test in python?

@ProfFan ProfFan merged commit d808d27 into develop Aug 22, 2023
26 checks passed
@ProfFan ProfFan deleted the fan/custom_robust branch August 22, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants