Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved wrapper/tests/documentation for some discrete classes #1579

Merged
merged 18 commits into from
Jul 18, 2023

Conversation

dellaert
Copy link
Member

These are all the cherry-picked commits from #1574, with one additional commit for the new normalization scheme in MPE.

(cherry picked from commit febeacd)
(cherry picked from commit 6cb0fa7)
(cherry picked from commit e180281)
(cherry picked from commit 40e5a1a)
(cherry picked from commit c8fe2fc)
(cherry picked from commit fa7bde7)
(cherry picked from commit 1f5e924)
(cherry picked from commit 3fd5c25)
(cherry picked from commit 9857e62)
(cherry picked from commit 0a24a8a)
(cherry picked from commit 10f30e1)
(cherry picked from commit 3d97976)
(cherry picked from commit 3edde4d)
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo 2 comments

gtsam_unstable/linear/tests/testQPSolver.cpp Show resolved Hide resolved
gtsam/inference/BayesTreeCliqueBase.h Outdated Show resolved Hide resolved
@dellaert dellaert merged commit b0a41d6 into develop Jul 18, 2023
@dellaert dellaert deleted the feature/discrete_wrapper branch July 18, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants