-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved wrapper/tests/documentation for some discrete classes #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit febeacd)
(cherry picked from commit 6cb0fa7)
(cherry picked from commit e180281)
(cherry picked from commit 40e5a1a)
(cherry picked from commit c8fe2fc)
(cherry picked from commit fa7bde7)
(cherry picked from commit 93d9ab6)
(cherry picked from commit 1f5e924)
(cherry picked from commit 3fd5c25)
(cherry picked from commit 9857e62)
(cherry picked from commit 0a24a8a)
(cherry picked from commit 10f30e1)
(cherry picked from commit 3d97976)
(cherry picked from commit 3edde4d)
varunagrawal
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo 2 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the cherry-picked commits from #1574, with one additional commit for the new normalization scheme in MPE.