-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap ISAM2 full update method #1569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a reformat
gtsam/nonlinear/nonlinear.i
Outdated
gtsam::ISAM2Result update(const gtsam::NonlinearFactorGraph& newFactors, | ||
const gtsam::Values& newTheta, | ||
const gtsam::FactorIndices& removeFactorIndices, | ||
gtsam::KeyGroupMap& constrainedKeys, | ||
const gtsam::KeyList& noRelinKeys, | ||
const gtsam::KeyList& extraReelimKeys, | ||
bool force_relinearize); | ||
bool force_relinearize=false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have space here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
def test_isam2_error(self): | ||
"""Test for isam2 error() method.""" | ||
#TODO(Varun) fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
And add some tests.