Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner ci #1565

Closed
wants to merge 1 commit into from
Closed

Cleaner ci #1565

wants to merge 1 commit into from

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Jul 1, 2023

Cleaner ci

@varunagrawal
Copy link
Collaborator

I don't think this is necessarily cleaner. Also we have special actions for push to develop which involve building the nightly packages.

@talregev
Copy link
Contributor Author

talregev commented Jul 1, 2023

I don't think this is necessarily cleaner. Also we have special actions for push to develop which involve building the nightly packages.

It easier to develop and add new functionality when the CI is cleaner. (The same work for code).
I can bring the old functionality and leave it as only cleaner yaml code.
We can discuss on new functionality on different PR if you open minded to hear my side.
If you insist. I can close this PR.

@varunagrawal
Copy link
Collaborator

Fair point but the CI isn't the focus of improvement right now. Also since we're open source, we don't get paid CI instances so it's a premium resource.

We prefer to run all tests on a local machine first to get things working and then push a PR for a collective check.

Hope that makes sense. :)

@talregev
Copy link
Contributor Author

talregev commented Jul 1, 2023

I am not sure which of the option I suggested you wanted. For now I am closing this PR.

@talregev talregev closed this Jul 1, 2023
@talregev talregev deleted the TalR/cleaner_ci branch August 26, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants