-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows tests #1562
Fix windows tests #1562
Conversation
@varunagrawal If you can approve the ci it will be great. |
Why not checkout my fix branch, make a branch off that and then target this PR to my branch? That will make the history clean and avoid duplication. |
Because it has conflict with develop when I do that. I solve also the conflict. |
Go ahead and do that. I'll resolve the conflict with develop on my branch when we merge this to #1553. |
I guess I have more problems. |
Okay wait I am resolving this here. |
7a718d7
to
04d975f
Compare
04d975f
to
bc51920
Compare
@talregev you should now be able to push to this PR without problems. |
@varunagrawal I want to add: concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true To all workflows. |
I love that idea! Also add a comment in the workflow file explaining that how you did over here. It is very useful! |
@varunagrawal Please approve again my CI :) |
It will affect on my next push. |
@varunagrawal Can you cancel the actions on previous commit? It will take forever until it start running on the new commit. |
…r_all_workflows Add non concurrency to all workflows
@varunagrawal I am done working on this branch. Thank you for your help. |
My commits above yours give better results: