Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindTBB.cmake: fix cmake error for TBB 2021 #1557

Closed
wants to merge 1 commit into from

Conversation

cdb0y511
Copy link

fix file failed to open for reading (No such file or directory): /usr/include/tbb/tbb_stddef.h inside docker build (TBB 2021.5 has removed the tbb_stddef.h)
related to #769

fix file failed to open for reading (No such file or directory):
 /usr/include/tbb/tbb_stddef.h
inside docker
@varunagrawal
Copy link
Collaborator

@cdb0y511 thanks for the contribution.

Your changes are throwing the error

CMake Error at cmake/FindTBB.cmake:186 (file):
  file failed to open for reading (No such file or directory):

    /usr/include/oneapi/tbb/version.h
Call Stack (most recent call first):
  cmake/HandleTBB.cmake:4 (find_package)
  CMakeLists.txt:79 (include)

Could it be that this change is not backwards compatible?

@talregev
Copy link
Contributor

talregev commented Jul 1, 2023

@cdb0y511
For fixing latest TBB, just delete the FindTBB.cmake file. Cmake already have a very good finding TBB for the new and for gtsam versions. I can make a PR for that, or you can try it your own.

@talregev
Copy link
Contributor

talregev commented Jul 3, 2023

@cdb0y511 Like mean that you want me to do it?
I will make a PR, and let me know if it work for you.

@varunagrawal
Copy link
Collaborator

Closing as this is superseded by #1567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants