fixed a bug which causes dispatcher crash #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with Python 3.10 and trying to jumpto some address the dispatcher processes crashed. When a new process connects to the dispatcher port but it does not intend to be a full functional client, the dispatcher server will assign a temporary `client` structure to it with name=None, however, the checks in server loop crashed as it tries to lowercase the None object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with Python 3.10 and trying to jumpto some address the dispatcher processes crashed.
When a new process connects to the dispatcher port but it does not intend to be a full functional client, the dispatcher server will assign a temporary
clientstructure to it with name=None, however, the checks in server loop crashed as it tries to lowercase the None object.