Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: string_token exposition #847

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

alandefreitas
Copy link
Member

fix #845

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (951477d) to head (cdf0521).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #847   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          157      157           
  Lines         8422     8422           
========================================
  Hits          8356     8356           
  Misses          66       66           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 951477d...cdf0521. Read the comment docs.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@alandefreitas alandefreitas force-pushed the docs-string-token branch 2 times, most recently from 21da6dd to c8ff4ec Compare July 9, 2024 22:46
@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@alandefreitas
Copy link
Member Author

@sdarwin The Antora workflow that generates the preview will probably break again. :(

The latest version of MrDocs bundles a more recent version of the Clang. That usually makes MrDocs incompatible with the system's std library. This leads to errors like this:

https://github.com/boostorg/url/actions/runs/9848619514/job/27191019492

To fix it, I updated the Antora workflow to install Clang 18 before running Antora + MrDocs:

https://github.com/boostorg/url/actions/runs/9865813807/job/27243495283?pr=847

I already opened an issue in MrDocs to try to make this more stable:

cppalliance/mrdocs#644

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://847.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

@alandefreitas alandefreitas merged commit 95e50b8 into boostorg:develop Jul 10, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing StringToken exposition
2 participants