master update for release. #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On FreeBSD I would like to remove dependency on libprocstat completely, and replace it with libkvm to be more like the other *BSD platforms in terms of linker dependencies. This pull request is our first move in that direction. Replace libprocstat with libkvm in cmd
_pipe_sink was assigned after call_on_setup(), after limit_fd_::on_setup(), but this was too late. It must be assigned earlier so that executor::get_used_handles() can see it and prevent limit_handles from closing the internal pipe for passing exec() errors from child to parent. Fixes: 1a1d677 Closes: #202 Signed-off-by: Daniel Klauer <[email protected]>
This re-adds the close(source) call which already existed here before commit caa7b2f. pipe_out already closes the source fd when redirecting stdout or stderr, it was just missing when redirecting both at once. The pipe fds must be closed after redirecting to avoid keeping the pipe open unnecessarily, for example the parent may want to close their end of the pipe. Closes: #353 Signed-off-by: Daniel Klauer <[email protected]>
Signed-off-by: Daniel Klauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.