bug fixes 1.85 #362
Merged
bug fixes 1.85 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit cbaa913 ("Merge branch 'develop' into limit_fd"), there have been merge conflicts in two files. In pipe_out.hpp, a previous commit from the "limit_fd" branch f8c0dd4 ("prototype for limit_fd") had been eliminated during wrong conflict resolution. The final result was, that file descriptors for stdout pipes were not preserved when using limit_handles. Example: boost::asio::io_context io_context; bp::async_pipe my_stdin(io_context); bp::async_pipe my_stdout(io_context); bp::child my_child("/usr/bin/echo", "Hello world", bp::std_in < my_stdin, // preserved by limit_handles bp::std_out > my_stdout, // closed by limit_handles bp::std_err > stderr, // preserved by limit_handles bp::limit_handles) Fixes: cbaa913 ("Merge branch 'develop' into limit_fd")
Fix off-by-one error. Currently, no handles are actually closed.
* Add more error handling to bp2::ext cwd.ipp. * Remove redundant errno checks these functions don't fail...
The initial value for the exit_code (0x7f) in v2 doesn't work with musl libc. Here WIFSIGNALED(0x7f) expands to a non-zero value: http://git.musl-libc.org/cgit/musl/tree/include/sys/wait.h#n54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.