Skip to content

Commit

Permalink
b2 link fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
klemens-morgenstern committed Jul 12, 2024
1 parent 8044857 commit 8b3e902
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ else()
endif()

if (WIN32)
target_link_libraries(boost_process PUBLIC ntdll)
target_link_libraries(boost_process PUBLIC ntdll shell32 Advapi32 user32)

This comment has been minimized.

Copy link
@Lastique

Lastique Jul 12, 2024

Member

Are you sure these dependencies are PUBLIC? The Jamfile adds these libraries in requirements, which is equivalent of PRIVATE in CMake.

endif()

if(BUILD_SHARED_LIBS)
Expand Down
12 changes: 12 additions & 0 deletions build/Jamfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,23 @@ alias process_sources
shell.cpp
;

if [ os.name ] = NT
{
lib shell32 ;
lib Advapi32 ;
lib Ntdll ;
lib user32 ;
}

lib boost_process
: process_sources
: requirements <define>BOOST_PROCESS_SOURCE=1
<link>shared:<define>BOOST_PROCESS_DYN_LINK=1
<boost.process.fs>boost:<library>/boost//filesystem
<target-os>windows:<library>shell32
<target-os>windows:<library>user32
<target-os>windows:<library>Ntdll
<target-os>windows:<library>Advapi32
: usage-requirements
<link>shared:<define>BOOST_PROCESS_DYN_LINK=1
<boost.process.fs>boost:<library>/boost//filesystem
Expand Down
5 changes: 0 additions & 5 deletions test/v2/Jamfile.jam
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,10 @@ exe target : target.cpp :
<target-os>windows:<source>Ntdll
;


lib test_impl : test_impl.cpp filesystem /boost//process :
<define>BOOST_PROCESS_V2_SEPARATE_COMPILATION=1
<define>BOOST_TEST_IGNORE_SIGCHLD=1
<link>static
<target-os>windows:<source>shell32
<target-os>windows:<source>user32
<target-os>windows:<source>Ntdll
<target-os>windows:<source>Advapi32
;

test-suite standalone :
Expand Down

0 comments on commit 8b3e902

Please sign in to comment.