Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HS (HTS) Code fields, as per fields supported by Shopify's API. #213

Merged

Conversation

c9845
Copy link

@c9845 c9845 commented May 26, 2023

This PR adds fields to handle Harmonized Tariff Schedule codes to the InventoryItem type. These fields exist in Shopify's API docs and are used to handle international shipments.

@c9845
Copy link
Author

c9845 commented May 26, 2023

Per #212.

Copy link
Collaborator

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f855f5e) 100.00% compared to head (b7b0b9e) 100.00%.

❗ Current head b7b0b9e differs from pull request most recent head bbac81a. Consider uploading reports for the commit bbac81a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         1715      1715           
=========================================
  Hits          1715      1715           
Impacted Files Coverage Δ
inventory_item.go 100.00% <ø> (ø)
variant.go 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@c9845
Copy link
Author

c9845 commented Jun 7, 2023

Hi @oliver006, any ideas of when this can be merged and a new release issued?

@oliver006
Copy link
Collaborator

Apologies for the delay - this is blocked due to an administrative mishap, I'm working wit the bold folks to sort that out. I'll merge this as soon as I can.

@oliver006 oliver006 merged commit 8e72785 into bold-commerce:master Jun 15, 2023
@MarkFullerInflxr
Copy link

What version is this fixed in? Im using 3.15.0 and just got the error json: cannot unmarshal object into Go struct field InventoryItem.inventory_item.country_harmonized_system_codes of type string

@c9845
Copy link
Author

c9845 commented Feb 13, 2024

country_harmonized_system_codes, aka CountryHarmonizedSystemCodes in InventoryItem is a []string, not a string. I imagine that is your issue...why it is occurring, I do not know. You would need to provide more context.

I am using v3.15.0 currently, but I only use the HarmonizedSystemCode field, and it has worked without issue for many months.

@oliver006
Copy link
Collaborator

My apologies, this was merged into master but no new release has been cut since then.

I'm still in the process of figuring out what else should go into 4.0 - a lot of PRs with breaking changes have been merged but there is still e.g. #4 (see here for more context)

I'll get a release out with this in the next 1-2 weeks, I just didn't have time recently.

@MarkFullerInflxr
Copy link

Happy Monday, just looking for an update on the ETA for v4. We only get this error sometimes so were dealing with it.

@oliver006
Copy link
Collaborator

oliver006 commented Feb 27, 2024

Thanks for the reminder and thanks for keeping me honest here!
I'm a little busy this week but will try to finalize the v4.0 release in the next few days weeks (barring any last minute surprises/changes re: #4 cc: @c9845 )

@MarkFullerInflxr
Copy link

Got a different but I assume related error to the harmonized field country_harmonized_system_codes: expected Array to be a Hash do we know if weve covered this one?

@MarkFullerInflxr
Copy link

I would assume so based on this field, but just wanted to make sure :) image

@oliver006
Copy link
Collaborator

@MarkFullerInflxr - not sure I follow. Are we good or is there something off here with regards to the HamonizedSystemCodes field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants