-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HS (HTS) Code fields, as per fields supported by Shopify's API. #213
Add HS (HTS) Code fields, as per fields supported by Shopify's API. #213
Conversation
Per #212. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1715 1715
=========================================
Hits 1715 1715
☔ View full report in Codecov by Sentry. |
Hi @oliver006, any ideas of when this can be merged and a new release issued? |
Apologies for the delay - this is blocked due to an administrative mishap, I'm working wit the bold folks to sort that out. I'll merge this as soon as I can. |
What version is this fixed in? Im using |
country_harmonized_system_codes, aka CountryHarmonizedSystemCodes in InventoryItem is a I am using v3.15.0 currently, but I only use the HarmonizedSystemCode field, and it has worked without issue for many months. |
My apologies, this was merged into master but no new release has been cut since then. I'm still in the process of figuring out what else should go into 4.0 - a lot of PRs with breaking changes have been merged but there is still e.g. #4 (see here for more context) I'll get a release out with this in the next 1-2 weeks, I just didn't have time recently. |
Happy Monday, just looking for an update on the ETA for v4. We only get this error sometimes so were dealing with it. |
Got a different but I assume related error to the harmonized field |
@MarkFullerInflxr - not sure I follow. Are we good or is there something off here with regards to the HamonizedSystemCodes field? |
This PR adds fields to handle Harmonized Tariff Schedule codes to the InventoryItem type. These fields exist in Shopify's API docs and are used to handle international shipments.