fix prometheus metrics #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some values (i.e. non numerical) must not be in the produced metrics. All metrics may have an optional `# HELP $description` line and should have a `# TYPE $metric_name $type` line. `address` and `unit` tags have been removed as they give no information you cannot get from the "HELP" lines. They have been replaced with `model` and `serial` tags to allow multiple inverters in the same prometheus instance. Other fixes: * add `charset=utf-8` to webserver Content-Type headers. * add `SH5.0RT-V112` that registers as 0xE0C * add description and type to registers-sungrow.yaml depends on bohdan-s/SungrowClient#4
this prefix will be prefixed to the prometheus metric name, e.g. for the register `internal_temperature` with a prefix of `sungrow_` the metric name will be `sungrow_internal_temperature`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some values (i.e. non numerical) must not be in the produced metrics.
All metrics may have an optional
# HELP $descriptionline and should have a# TYPE $metric_name $typeline.addressandunittags have been removed as they give no information you cannot get from the "HELP" lines. They have been replaced withmodelandserialtags to allow multiple inverters in the same prometheus instance.Other fixes:
charset=utf-8to webserver Content-Type headers.SH5.0RT-V112that registers as 0xE0C (see also registers-sungrow.yaml: Add SH5.0RT that registers as 0xE0C #113)depends on bohdan-s/SungrowClient#4