Skip to content

Commit

Permalink
request some specific feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
bogovicj committed Aug 14, 2024
1 parent e95eaf6 commit d1a5367
Showing 1 changed file with 55 additions and 0 deletions.
55 changes: 55 additions & 0 deletions rfc/wip-tform/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,61 @@ Practically, non-invertible transformations have finite extents, so bijection tr
to be correct / consistent for points that fall within those extents. It may not be correct for any point of
appropriate dimensionality.

## Specific feedback requested

We ask the reviewers for one specific piece of feedback. Specifically about whether parameters for transformations should
be written as they are currently in the draft pull request, with named parameters at the "top level" e.g.:

```
{
"type": "affine",
"affine": [[1, 2, 3], [4, 5, 6]],
"input": "ji",
"output": "yx"
}
```

or alternatively in a `parameters` field:

```
{
"type": "affine",
"parameters": {
"matrix": [[1, 2, 3], [4, 5, 6]]
},
"input": "ji",
"output": "yx"
}
```

In discussions, some authors preferred the latter because it will make the "top-level" keys for transformation
objects all identical, which could make serialization / validation simpler. One downside is that this change
is breaking for the existing `scale` and `translation` transformations

```
{
"type": "scale",
"scale": [2, 3, 4],
"input": "ji",
"output": "yx"
}
```

would change to:

```
{
"type": "scale",
"parameters": {
"scale": [2, 3, 4],
},
"input": "ji",
"output": "yx"
}
```

The authors would be interested to hear perspectives from the reviewers on this matter.


## Requirements

Expand Down

0 comments on commit d1a5367

Please sign in to comment.