Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add hyper pane #206

Merged
merged 3 commits into from
Feb 10, 2017
Merged

Feat/add hyper pane #206

merged 3 commits into from
Feb 10, 2017

Conversation

iamstarkov
Copy link
Collaborator

navigate through panes with arrows — plugin we all wanted
https://www.npmjs.com/package/hyper-pane

/cc @chabou

@darahak
Copy link
Collaborator

darahak commented Feb 9, 2017

Nothing to do with the PR, but we get 429 HTTP errors on the CI tests now ("too many requests").
Is there a way to throttle these requests?

Copy link
Collaborator

@darahak darahak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better readability, maybe add whitespace between the + operators.
Otherwise it's cool 👍

@chabou
Copy link
Collaborator

chabou commented Feb 9, 2017

@iamstarkov ❤️ you made my day

I would suggest to not mention shortcut because it will be configurable very soon.
Something like: "Navigate through panes with arrows or jump directly to a specific pane with digit" or something like that.
(No need to mention "switch" functionality)

@iamstarkov
Copy link
Collaborator Author

@chabou fixed description here and i think you would need to update yours github/npm/readme descriptions as well =)

@iamstarkov
Copy link
Collaborator Author

@darahak

Is there a way to throttle these requests?

i dont know, why do we need to use API for linting README files

@darahak
Copy link
Collaborator

darahak commented Feb 10, 2017

It looks for dead links, so I guess it's useful but it generates a lot of false positives 🤷‍♂️
Probably something to be discussed on #180

@darahak darahak merged commit 3fca894 into master Feb 10, 2017
@iamstarkov iamstarkov deleted the feat/add-hyper-pane branch February 11, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants