Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.14.0 #105

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Release 0.14.0 #105

merged 1 commit into from
Dec 7, 2024

Conversation

bluzky
Copy link
Owner

@bluzky bluzky commented Dec 7, 2024

Summary by Sourcery

Enhancements:

  • Refactor the dialog component to streamline the modal show and hide logic.

Copy link

sourcery-ai bot commented Dec 7, 2024

Reviewer's Guide by Sourcery

This PR updates the dialog component implementation by simplifying the modal hide/show logic and bumps the package version from 0.14.3 to 0.14.4.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Simplified modal dialog hide/show implementation
  • Removed separate phx-remove event handler
  • Combined hide modal and cancel functionality into a single handler
  • Removed data-cancel attribute
lib/salad_ui/dialog.ex
Version bump for package release
  • Incremented version from 0.14.3 to 0.14.4
mix.exs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bluzky bluzky merged commit f72ec0a into main Dec 7, 2024
2 checks passed
@bluzky bluzky deleted the v0.14.4 branch December 7, 2024 14:12
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bluzky - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andrejj
Copy link

andrejj commented Dec 9, 2024

Hi. I tried to use the modal and I still see it fail: @bluzky
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants