Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues from #92 and #93 #99

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix issues from #92 and #93 #99

wants to merge 3 commits into from

Conversation

SajanGhuman
Copy link
Contributor

@SajanGhuman SajanGhuman commented Nov 12, 2024 •
edited by mahid797
Loading

This PR resolves all the issues from issue #93 (Improve User Authentication Flow) and issue #93 (Authentication back-end fixes).

Enhance Forgot Password Workflow

  • Implement tokenization for secure password reset
  • Send a Reset Password email that directs users to the reset-password page

Email Verification

  • Send a verification email to users upon signup.
  • Prevent users from signing in until email verification is completed.

Automatic Login after Password Reset

  • Automatically log in users after they successfully reset their password.
  • Route users to the "Documents" page upon clicking the confirmation button on the password-reset-confirm page, instead of redirecting them to the sign-in page.

Fix Sign-In and Log-Out Flickering Issue

  • Resolve the flickering that occurs on the Sign-In and Log-Out pages.

Remove Placeholder Authentication UI

  • Delete any placeholder Auth UI pages and folders to clean up the codebase.

Update User Schema

  • Add fields for First Name and Last Name.
  • Set default User role to "Admin".

@SajanGhuman SajanGhuman self-assigned this Nov 12, 2024
@SajanGhuman SajanGhuman added New Feature New feature to be implemented Refactor Code Improvement Backend Backend Related Issue Core Work to do on the core system of the App labels Nov 12, 2024
This was linked to issues Nov 12, 2024
Authentication Backend Fixes #92
Open
Improve User Authentication Flow #93
Open
@SajanGhuman
Copy link
Contributor Author

There is a small bug with "Automatic Login after Password Reset". Will be fixed soon.

mahid797
mahid797 requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@mahid797 mahid797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job👍🏼

Client/prisma/schema.prisma Show resolved Hide resolved
Client/src/app/api/auth/resetPass/route.ts Outdated Show resolved Hide resolved
Client/src/app/auth/forgot-password/page.tsx Outdated Show resolved Hide resolved
Client/src/app/auth/reset-password/[token]/page.tsx Outdated Show resolved Hide resolved
Client/src/components/welcome_email.tsx Outdated Show resolved Hide resolved
Client/src/app/auth/sign-up/page.tsx Outdated Show resolved Hide resolved
@SajanGhuman
Copy link
Contributor Author

There is a small bug with "Automatic Login after Password Reset". Will be fixed soon.

This is fixed now. When the user reset their password, They can auto sign in with a button click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem-bwl gorkem-bwl gorkem-bwl left review comments

@mahid797 mahid797 mahid797 requested changes

@Paxxack Paxxack Awaiting requested review from Paxxack

Assignees

@SajanGhuman SajanGhuman

Labels
Backend Backend Related Issue Core Work to do on the core system of the App New Feature New feature to be implemented Refactor Code Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve User Authentication Flow Authentication Backend Fixes
3 participants
@SajanGhuman @mahid797 @gorkem-bwl