Restructure epics/test_signals.py #630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
reviewed
Oct 30, 2024
tests/epics/signal/test_signals.py
Outdated
Comment on lines
102
to
70
| async def _make_backend(typ: type | None, protocol: str, suff: str, timeout=10.0): | ||
| pv = f"{protocol}://{PV_PREFIX}:{protocol}:{suff}" | ||
| # Make and connect the backend | ||
| backend = _epics_signal_backend(typ, pv, pv) | ||
| await backend.connect(timeout=timeout) | ||
| return backend |
There was a problem hiding this comment.
Can we replace this with getattr(device, suffix) in some way?
jsouter
force-pushed
the
signals_tests
branch
2 times, most recently
from
f4afeb4
to
d3eb221
Compare
jsouter
force-pushed
the
signals_tests
branch
from
7305914
to
2a1b056
Compare
jsouter
force-pushed
the
signals_tests
branch
from
2a1b056
to
a819a88
Compare
|
Will update test_device_save_loader to use the the example PvaDevice class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #385
Now has a single IOC containing all the CA and PVA records, and a Device group which provides access to them.