Rename hdf5_type to data_type in DatasetTable (#651)

* Rename hdf5_type to data_type in DatasetTable * Actually use dtype, cleaner table name on IOC side that way
bluesky · Nov 14, 2024 · ec4b7d0 · ec4b7d0
1 parent b4216eb
commit ec4b7d0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/ophyd_async/fastcs/panda/_table.py b/src/ophyd_async/fastcs/panda/_table.py
@@ -13,7 +13,7 @@ class PandaHdf5DatasetType(StrictEnum):
 
 class DatasetTable(Table):
     name: Sequence[str]
-    hdf5_type: Sequence[PandaHdf5DatasetType]
+    dtype: Sequence[PandaHdf5DatasetType]
 
 
 class SeqTrigger(StrictEnum):

diff --git a/tests/fastcs/panda/test_hdf_panda.py b/tests/fastcs/panda/test_hdf_panda.py
@@ -47,7 +47,7 @@ def check_dir_exits(value, **kwargs):
         mock_hdf_panda.data.datasets,
         DatasetTable(
             name=["x", "y"],
-            hdf5_type=[PandaHdf5DatasetType.UINT_32, PandaHdf5DatasetType.FLOAT_64],
+            dtype=[PandaHdf5DatasetType.UINT_32, PandaHdf5DatasetType.FLOAT_64],
         ),
     )
 

diff --git a/tests/fastcs/panda/test_writer.py b/tests/fastcs/panda/test_writer.py
@@ -27,11 +27,11 @@
 TABLES = [
     DatasetTable(
         name=[],
-        hdf5_type=[],
+        dtype=[],
     ),
     DatasetTable(
         name=["x"],
-        hdf5_type=[PandaHdf5DatasetType.UINT_32],
+        dtype=[PandaHdf5DatasetType.UINT_32],
     ),
     DatasetTable(
         name=[
@@ -40,7 +40,7 @@
             "y_min",
             "y_max",
         ],
-        hdf5_type=[
+        dtype=[
             PandaHdf5DatasetType.UINT_32,
             PandaHdf5DatasetType.FLOAT_64,
             PandaHdf5DatasetType.FLOAT_64,
@@ -82,7 +82,7 @@ def check_dir_exits(value, **kwargs):
         mock_panda.data.datasets,
         DatasetTable(
             name=[],
-            hdf5_type=[],
+            dtype=[],
         ),
     )