Notifications: appearance tweaks for loading placeholder #6134
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After a bit of UI investigation it looks like most of list placeholders skips entry border. Happy to revert the border addition, if it is an established pattern. 🙂 |
|
Yea let's skip for consistency (and then maybe add it everywhere haha) |
gaearon
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I have spotted that Notifications loading placeholder diverged slightly from feed entry appearance.
Kapture.2024-11-06.at.23.45.49.mp4
How
Tweak sizing of and spacing between loading placeholder elements, add bottom border, randomize second text line width to break up visual repetition a bit.
Preview
Kapture.2024-11-06.at.23.29.58.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-06.at.23.33.10.mp4