Feature/string push #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluebrown
requested changes
Jul 20, 2023
| return nil | ||
| case "text/plain": | ||
| var text = string(b[:]) | ||
| if len(text) < 10 { |
There was a problem hiding this comment.
probably, its better to check if the received string is an actual valid image reference.
internal/server/webhooks.go
Outdated
| @@ -31,9 +29,11 @@ func RequireHeaders(headers []kobold.Header, handler http.Handler) http.Handler | |||
| func NewPushWebhook(id string, subs []chan events.PushData, ph events.PayloadHandler) http.Handler { | |||
| logger := log.With().Str("endpoint", id).Logger() | |||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| logger.Info().Str("endpoint", id).Msg("push event received") | |||
| var ct string = r.Header.Get("Content-Type") | |||
| logger.Info().Str("endpoint", id).Msg(fmt.Sprintf("push event received with Content-Type: %s", ct)) | |||
There was a problem hiding this comment.
zerolog is based on structured data. So it would be more idiomatic to add another Str call before the message
Something like below:
logger.Info().Str("endpoint", id).Str("contentType", ct).Msg("push event received")| @@ -13,6 +13,7 @@ require ( | |||
| github.com/google/go-licenses v1.6.0 | |||
| github.com/hashicorp/go-retryablehttp v0.7.4 | |||
| github.com/mitchellh/mapstructure v1.5.0 | |||
| github.com/novln/docker-parser v1.0.0 | |||
There was a problem hiding this comment.
Do you think this is really required? I would assume there is a way around it. That library is quite old and not alot used. I think its possible to get the tag from the google other library.
bluebrown
force-pushed
the
main
branch
3 times, most recently
from
3fdab58
to
d9d064f
Compare
|
Closing as its already implemented by #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #18
as discussed ability too push strings