Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display empty NFT attributes #2348

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Do not display empty NFT attributes #2348

merged 1 commit into from
Nov 4, 2024

Conversation

tom2drum
Copy link
Collaborator

Description and Related Issue(s)

Fixes #2337

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@tom2drum tom2drum self-assigned this Oct 31, 2024
@tom2drum tom2drum requested a review from isstuev October 31, 2024 17:17
@github-actions github-actions bot added the bug Something isn't working label Oct 31, 2024
@tom2drum tom2drum merged commit f53a360 into main Nov 4, 2024
12 checks passed
@tom2drum tom2drum deleted the tom2drum/issue-2337 branch November 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isstuev isstuev isstuev approved these changes

Assignees

@tom2drum tom2drum

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not display empty NFT attributes
2 participants
@tom2drum @isstuev