Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookup_methods endpoint #668

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Add lookup_methods endpoint #668

merged 6 commits into from
Nov 14, 2023

Conversation

lok52
Copy link
Contributor

@lok52 lok52 commented Nov 6, 2023

Add lookup-methods endpoint for solidity contracts. Internally PoC logic from sol-abi-jumps library is used.

@lok52 lok52 force-pushed the lok52/lookup-methods branch from ecfb790 to 80031ff Compare November 10, 2023 16:11
@lok52 lok52 force-pushed the lok52/lookup-methods branch from 80031ff to 2b67796 Compare November 10, 2023 16:34
Copy link
Member

@rimrakhimov rimrakhimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. We can merge it, I believe. Added just small nits with some suggestions below

@lok52 lok52 merged commit a1db0d4 into main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants