Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: language server toolkit #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukealvoeiro
Copy link
Contributor

@lukealvoeiro lukealvoeiro commented Oct 17, 2024

Description

This PR creates the language server toolkit. This toolkit is used to stand up & communicate with language servers over the language server protocol. It draws heavy inspiration from https://github.com/microsoft/multilspy.

Remaining work

The following work will not be implemented in this PR, but is required before we make language servers part of the default:

  • Prompt engineer a way to reliably convert searches for a symbol into requests to the LSP (instead of current ripgrep).
  • (Blocked by above) Determine whether this is a net improvement over the current implementation.
  • Tune the number of surrounding lines shown in the response from the language server.
  • (Potentially) Use request_document_symbols to better inform context (though there is some evidence from Aider that this doesn't scale well on large repos).
  • Implement the TODO in session.py@line:189, to update the language server about any files that may have been changed by the user while goose is running.

@lukealvoeiro lukealvoeiro changed the base branch from use-lsp to main October 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant