Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #472 #478

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixes #472 #478

wants to merge 1 commit into from

Conversation

D-a-n-i-l-o
Copy link
Contributor

Fix for the problem with '=' character in filenames/paths.

@nitrologic
Copy link

Has this change been tested with modules and imported files?

Paths in monkey2 often infer scope which I suspect would appreciate decl characters only.

@D-a-n-i-l-o
Copy link
Contributor Author

D-a-n-i-l-o commented Jun 5, 2019

I'm using the fix since April 15th 2019 and found no problems.

I re-compiled modules several times and had no problems,
but modules don't use '=' in path anyway.

Monkey2 thinks that something with '=' is an compiler option, for example:

  • "-target=desktop"
  • "-config=debug"
  • "users/name/monkey/= Tests =/myfile.monkey2"

The fix just checks if the option starts with "-", because all options start with "-":

  • "-target="
  • "-config="

Paths like "users/name/monkey/= Tests =/myfile.monkey2" do not start with a "-",
otherwise the compiler would again think it is an option.

This fix does not touch anything in the compiler. It is in mx2cc.monkey2 command-line parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants