[PS-2099] PostgreSQL EF Contains() in SQL Query is strpos(), witch is case-sens… #2512
Conversation
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
djsmith85
added
the
bw-unified-deploy
|
Hi @juliokele thank you so much for this contribution. Did you by chance test this against MySQL to make sure this solution still allowed it to work properly? |
|
I have tested against MySQL and working properly. |
| @@ -28,7 +28,7 @@ public virtual IQueryable<CipherDetails> Run(DatabaseContext dbContext) | |||
| DeletedDate = c.DeletedDate, | |||
| Reprompt = c.Reprompt, | |||
| Favorite = _userId.HasValue && c.Favorites != null && c.Favorites.Contains($"\"{_userId}\":true"), | |||
There was a problem hiding this comment.
Dont we have this same problem here too? I think we do these kinds of checks in some other areas too. @justindbaur UserCipherDetailsQuery maybe?
There was a problem hiding this comment.
yes, the same problem (Favorite is upper-case too):
| @@ -28,7 +28,7 @@ public virtual IQueryable<CipherDetails> Run(DatabaseContext dbContext) | |||
| DeletedDate = c.DeletedDate, | |||
| Reprompt = c.Reprompt, | |||
| Favorite = _userId.HasValue && c.Favorites != null && c.Favorites.Contains($"\"{_userId}\":true"), | |||
| FolderId = (_ignoreFolders || !_userId.HasValue || c.Folders == null || !c.Folders.Contains(_userId.Value.ToString())) ? | |||
| FolderId = (_ignoreFolders || !_userId.HasValue || c.Folders == null || !c.Folders.ToLowerInvariant().Contains(_userId.Value.ToString())) ? | |||
There was a problem hiding this comment.
Do we need to ensure _userId is lowercase as well?
|
@kspearrin |
|
@juliokele no worries, we're trying to figure out some issues with unsigned commits before being able to merge. |
|
@justindbaur Should we merge this for next release? |
|
@kspearrin Yes we should, have we figured out the unsigned commit issue? |
After Items importing the Cipher/Folders value is uppercase.
PostgreSQL EF Contains() under the hood in SQL Query is strpos(), witch is case-sensitive.