Preserve permission bits on updateself #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,9 @@ echo "" | |||
| function downloadSelf() { | |||
| if curl -L -s -w "http_code %{http_code}" -o $SCRIPT_PATH.1 $BITWARDEN_SCRIPT_URL | grep -q "^http_code 20[0-9]" | |||
There was a problem hiding this comment.
The normal method of controlling permissions is to specifically set them, not to merely copy them and rely on the history of permissions of the previous deployment. Relying on history that is out of the control of the deployment tool creates uncertainty of deployment, a dangerous practice for a security tool.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to preserve any changed permissions on the
bitwarden.shscript when updating it (withupdateself).For example, I like to have my instances
bitwarden.shto be group executable, so this change would keep it group executable after updates.One thing is that I'm not sure whether the --reference option to chmod is specific to the GNU implementation. Is that is a concern?