Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard "docker-compose" in favor of "docker compose" #222

Open
sincerelysaucy opened this issue Mar 1, 2024 · 5 comments · May be fixed by #301
Open

Discard "docker-compose" in favor of "docker compose" #222

sincerelysaucy opened this issue Mar 1, 2024 · 5 comments · May be fixed by #301

Comments

@sincerelysaucy
Copy link

The published "docker-compose" binary is obsolete and unmaintained, and the "docker compose" plugin is actively being supported and built into contemporary releases of docker. Please discard the use of "docker-compose" or at least check for and use "docker compose" first in the bitwarden.sh, run.sh, and run.ps1 files. Its use encourages separately installing and relying on obsolete software, which should not be welcomed for security related software.
@Greenderella
Copy link
Member

Hi there,

This report has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

@Greenderella Greenderella mentioned this issue Mar 29, 2024
Closed
@vinnyperella
Copy link

The above issue, #232, is unrelated to this issue.

My instance is successfully using the 'docker compose' binary located in $HOME/.docker/cli-plugins

bitwarden@bitwarden:/opt/bitwarden$ which docker-compose
bitwarden@bitwarden:/opt/bitwarden$ docker compose version
Docker Compose version v2.26.1
bitwarden@bitwarden:/opt/bitwarden$ ~/.docker/cli-plugins/docker-compose version
Docker Compose version v2.26.1
bitwarden@bitwarden:/opt/bitwarden$ ./bitwarden.sh updateself
 _     _ _                         _            
| |__ (_) |___      ____ _ _ __ __| | ___ _ __  
| '_ \| | __\ \ /\ / / _` | '__/ _` |/ _ \ '_ \ 
| |_) | | |_ \ V  V / (_| | | | (_| |  __/ | | |
|_.__/|_|\__| \_/\_/ \__,_|_|  \__,_|\___|_| |_|

Open source password management solutions
Copyright 2015-2024, 8bit Solutions LLC
https://bitwarden.com, https://github.com/bitwarden

===================================================

bitwarden.sh version 2024.3.0
Docker version 26.0.0, build 2ae903e
Docker Compose version v2.26.1 <=============== latest Docker Compose release from Github

Updated self.
bitwarden@bitwarden:/opt/bitwarden$

I manually update this file using the Docker Compose Github releases page https://github.com/docker/compose/releases.

I do not have the binary that comes with the apt package docker-compose-plugin in my system path so it's not being used.

bitwarden@bitwarden:~$ dpkg -L docker-compose-plugin
/.
/usr
/usr/libexec
/usr/libexec/docker
/usr/libexec/docker/cli-plugins
/usr/libexec/docker/cli-plugins/docker-compose
/usr/share
/usr/share/doc
/usr/share/doc/docker-compose-plugin
/usr/share/doc/docker-compose-plugin/changelog.Debian.gz
bitwarden@bitwarden:~$ /usr/libexec/docker/cli-plugins/docker-compose version
Docker Compose version v2.25.0
bitwarden@bitwarden:~$

@sincerelysaucy
Copy link
Author

The #232 actually is related. If you manually install "docker-compose", the "bitwarden.sh" script is written to use it by preference. And it's obsolete and unsupported, and should no longer even be attempted in place of the better supported "docker compose" command.

@fuglphoenix
Copy link

fuglphoenix commented Sep 18, 2024 •
edited
Loading

just adding my experience/pain regarding the use of docker-compose in the bitwarden.sh script 😅
my ubuntu installation contained the snap version of docker-compose. which messed up the bitwarden.sh start command. it would just error out and say something like

docker-compose.yml file doesn't exists. 
stat /opt/bitwarden/bwdata/docker/docker-compose.yml

even though it actually does exists.
it turns out the env var COMPOSE_FILE didn't work correctly when using docker-compose.
the fix was to remove docker-compose

@nkadel
Copy link

nkadel commented Sep 18, 2024

Do you need a pull request for this? Because the old 'docker-compose' binary is now six months older.

@djsmith85 djsmith85 linked a pull request Oct 30, 2024 that will close this issue
Breaking change: remove support for deprecated docker-compose CLI #301
Open
@tangowithfoxtrot tangowithfoxtrot linked a pull request Oct 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking change: remove support for deprecated docker-compose CLI bitwarden/self-host
5 participants
@vinnyperella @fuglphoenix @nkadel @Greenderella @sincerelysaucy