Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10877] New workflows for version calculation and workflow dispatch #3902

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 10, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-10877

๐Ÿ“” Objective

First step in moving version calculation to it's own file. Also adds a new composite action to dispatch, wait and download artifacts from other workflows. We need these in main before we're able to use them in our existing build workflow.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 88.66%. Comparing base (98bcff5) to head (4370a87).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3902   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         414      414           
  Lines       33935    33935           
  Branches     5004     5004           
=======================================
  Hits        30090    30090           
  Misses       2088     2088           
  Partials     1757     1757           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 8e1a7d9d-81e6-43b5-90e9-5ecdc2bddd68

No New Or Fixed Issues Found

@vvolkgang vvolkgang marked this pull request as draft November 21, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants