Merge pull request #80 from matiu/bug/rounding-errors

fixes rounding errors in fees and valueout
bitpay · May 17, 2014 · 8da8724 · 8da8724
2 parents 667c605 + f537db4
commit 8da8724
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/insight.js b/insight.js
diff --git a/lib/Rpc.js b/lib/Rpc.js
@@ -31,10 +31,10 @@ Rpc._parseTxResult = function(info) {
   var valueOutSat = 0;
   info.vout.forEach( function(o) {
     o.value = o.value.toFixed(8);
-    valueOutSat += o.value * bitcore.util.COIN;
+    valueOutSat += (o.value * bitcore.util.COIN).toFixed(0);
     delete o.scriptPubKey.hex;
   });
-  info.valueOut = parseInt(valueOutSat) / bitcore.util.COIN;
+  info.valueOut = valueOutSat / bitcore.util.COIN;
   info.size     = b.length;
 
   return info;

diff --git a/lib/TransactionDb.js b/lib/TransactionDb.js
@@ -241,7 +241,7 @@ isspent
     function() {
       if (!incompleteInputs) {
         info.valueIn = valueIn / util.COIN;
-        info.fees = (valueIn - parseInt(info.valueOut * util.COIN)) / util.COIN;
+        info.fees = (valueIn - (info.valueOut * util.COIN)).toFixed(0) / util.COIN;
       } else {
         info.incompleteInputs = 1;
       }