Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add regtest multisig support; Fix multisig wallet selection #1265

Merged
merged 11 commits into from
Aug 30, 2024

Conversation

kajoseph
Copy link
Contributor

@kajoseph kajoseph commented Jul 22, 2024

This PR:

  • Adds regtest multisig support
  • Finds wallets by id+copayerId. This fixes an issue when you have mulitple copayers to the same multisig wallet on the same device. The existing find behavior returns the first wallet that matches the id, so drilling into the wallet for copayers >1 displays (and signs with, exports, etc.) copayer 1. Finding the wallet by id+copayerId returns the correct copayer wallet.

This PR depends on bitpay/bitcore#3773 (merged in bitcore 10.3.0) in order to build and parse the regtest multisig secret. Would whoever approves this PR also approve the bitcore PR since it's small and directly dependent?

@kajoseph kajoseph changed the title [REF] Add regtest multisig support; Fix musig wallet selection [REF] Add regtest multisig support; Fix multisig wallet selection Jul 22, 2024
@JohnathanWhite JohnathanWhite merged commit 99dbee5 into bitpay:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants