Fix lighthouse geometry estimation example #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gemenerik
commented
Jun 27, 2024
•
gemenerik
commented
- Fixed the data collection reattempts. ensuring the loop runs again if necessary to successfully obtain recordings.
- Refactored code by consolidating data recording processes into dedicated functions for improved organization and readability.
- Implemented timeouts in the data recording functions to prevent indefinite blocking
* Fixed broken while loops that were incorrectly exiting immediately without retries. * Gathered data recording code into functions. Implemented timeout and retry mechanism in record_angles_average. * Added timeouts for recording data
gemenerik
force-pushed
the
rik/bs_geo_est_fix
branch
from
b8b5f8a
to
d6e5c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.