pcap logging; Timestamps wrapping after 59 seconds. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the issue from this discussion; |
ToveRumar
force-pushed
the
toverumar/fix_wireshark_time
branch
2 times, most recently
from
29df085
to
599be51
Compare
|
Wireshark wiki confirms it should be seconds since Unix time. You could consider using time.time() since that returns Unix time in seconds. |
ToveRumar
force-pushed
the
toverumar/fix_wireshark_time
branch
from
599be51
to
1a2d3cb
Compare
The datetime object does not hold total seconds since Epoch time.The seconds variable is only seconds since last full minute. We need a deltatime since Epoch start to get total seconds since then
ToveRumar
force-pushed
the
toverumar/fix_wireshark_time
branch
from
1a2d3cb
to
b875fca
Compare
I liked that solution better. See update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datetime object does not hold total seconds since Epoch time.The seconds variable is only seconds since last full minute. We need a deltatime since Epoch start to get total seconds since then