Update sbs_connect_log_param.md #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple_log function has wrong parameter logconf, which is not be used in the simple_log, the parameter name should be 'lg_stab' or change 'lg_stab' var as 'logconf' instead
knmcguire
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Thanks for noticing, this is indeed a bug!
Actually it should be the other way around. The function call should have logconf in there and the lg_stab in simple_log should be renamed logconf.
Could you also change it in the sbs code example as well? So to change lg_stab here to logconf:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple_log function has wrong parameter logconf, which is not be used in the simple_log, the parameter name should be 'lg_stab' or change 'lg_stab' var as 'logconf' instead