Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sbs motion commander #410

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Update sbs motion commander #410

merged 2 commits into from
Jul 26, 2023

Conversation

krichardsson
Copy link
Contributor

This PR corrects the documentation of the SBS motion commander.

The current text mentions that any positiong deck works, while the code only checks for the flow deck. This PR changes the text to only mention the flow deck

knmcguire
knmcguire reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a note somewhere, that another positioning deck can be used but that a different parameter needs to be checked?

@knmcguire knmcguire merged commit 294e9cb into master Jul 26, 2023
1 check passed
@krichardsson krichardsson deleted the krichardsson/sbs-motion branch August 29, 2023 12:26
@knmcguire knmcguire added this to the next-release milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knmcguire knmcguire knmcguire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.24
Development

Successfully merging this pull request may close these issues.
2 participants
@krichardsson @knmcguire