-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building and flashing guide improvements #1395
Conversation
…nd removed the example for the roadrunner defconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is unfortunately an issue, this will break tb docs
of the toolbelt of building the documentation locally so it always need to be build as a submodule from the website. It won't know what the meaning of the tab group is otherwise
Another thing ofcourse is that now the markdown itself is less readable by itself. So unfortunately I do think that we need to discuss this break first before merging. We need to align on what is accepted within the repo doc files or not.
The main point of this PR was to make it clear that for brushless people will need to use another defconfig. I removed the Jekyll liquid tags, let's discuss those another time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed the
make flash
in the section of ###using a debug adapter. But rest looks good! From my part not a blocker so you can also merge as is.
Main goal of this PR is to clarify that brushless uses a different defconfig
Major changes:
Minor changes: