Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - logGetVarId - Return Log ID that matches the Log ID in Logs TOC #1302

Closed
wants to merge 1 commit into from

Conversation

sabulaban
Copy link

Current implementation does not return the correct log ID that matches TOC for logGetVarId, this is a fix to address that, within the fix, the return value matches the log ID as defined in the TOC.

@ataffanel
Copy link
Member

Thanks for the PR!

This bug surprises me since we have been using this functionality in a lot of our demos and we have not seen any problem with it. I will take a closer look.

@ataffanel
Copy link
Member

This PR does not seems to work.

I tested the example/app_internal_param_log and without the PR I get expected output from internal logs (the yaw is a slowly drifting number starting around 0):

Yaw is now: 0.013700 deg
Estimator type is now: 1 deg
ESTIMATOR: Using Kalman (2) estimator
Yaw is now: 0.006027 deg
Estimator type is now: 2 deg
Yaw is now: 0.002112 deg
Estimator type is now: 2 deg
Yaw is now: -0.003149 deg
Estimator type is now: 2 deg

With the PR I do not (this is not showing the yaw log value):

Yaw is now: 0.0 deg
Estimator type is now: 1 deg
ESTIMATOR: Using Kalman (2) estimator
Yaw is now: 0.0 deg
Estimator type is now: 2 deg
Yaw is now: 0.0 deg
Estimator type is now: 2 deg
Yaw is now: 0.0 deg
Estimator type is now: 2 deg
Yaw is now: 0.0 deg

I am closing the PR. If you feel like I missed something do not hesitate to re-open it.

@ataffanel ataffanel closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants