-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
64bit arithmetic op codes #1538
base: master
Are you sure you want to change the base?
Conversation
Why not push the overflow amount and the result back on the stack? Rather than This would simply doing 256-bit math from 64-bit stack elements and I don't see any downsides for 64-bit operations. |
Sorry I don't understand this. Could you maybe give a more concrete example, perhaps on delvingbitcoin? We have a thread going here: https://delvingbitcoin.org/t/64-bit-arithmetic-soft-fork/397/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a light first pass. I noticed that this document may be missing a Rationale Section that describes design decisions, alternate approaches, and related work, and a Backwards Compatibility section.
You may want to add the "Post-History" header to the preamble to link to discussions of this proposal on the mailing list or forums.
Title: 64 bit arithmetic operations | ||
Author: Chris Stewart <[email protected]> | ||
Comments-Summary: No comments yet. | ||
Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0364 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refrain from issuing your own BIP numbers.
<pre> | ||
BIP: TBD | ||
Layer: Consensus (soft fork) | ||
Title: 64 bit arithmetic operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
Title: 64 bit arithmetic operations | |
Title: 64-bit arithmetic operations |
Hey @Christewart, are you still working on this? |
Yep i'm going to give it another go. I'll update soon. |
This BIP describes a soft fork to add 64-bit arithmetic op codes to bitcoin
Implementation: bitcoin/bitcoin#29221