Schnorr (Incremental) Half Aggregation #1566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjones3695
approved these changes
Jul 16, 2024
fjahr
force-pushed
the
2024-07-half-agg
branch
2 times, most recently
from
6218bda to
0effa49
Compare
|
Rebased on the musig changes and added the compile options for cmake |
fjahr
force-pushed
the
2024-07-half-agg
branch
4 times, most recently
from
31c6b5d to
db91a39
Compare
Co-authored-by: Benedikt <[email protected]>
- we may want to add a header to the include file that links to the BIP - there's still a mention of aggsig_size - we may want to move aggregate before inc_aggregate - we should mention expected size of input aggsig array in_aggregate - 'Should be aggsig_len = 32*(n+1)' -> 'Must be'
fjahr
force-pushed
the
2024-07-half-agg
branch
from
db91a39 to
bcd6b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports over the work from b-wagn in BlockstreamResearch/secp256k1-zkp#261
In the second commit I have addressed the follow-ups though I was not always sure if I understood them correctly since they weren't inline. Please let me know if they are correct then I can squash the commit here and open it as a PR on zkp.